Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Add memory and CPU resource limits to containers#111

Merged
openshift-merge-bot[bot] merged 2 commits into
openstack-lightspeed:lcore-migrationfrom
omkarjoshi0304:lcore
Jun 12, 2026
Merged

Add memory and CPU resource limits to containers#111
openshift-merge-bot[bot] merged 2 commits into
openstack-lightspeed:lcore-migrationfrom
omkarjoshi0304:lcore

Conversation

@omkarjoshi0304

@omkarjoshi0304 omkarjoshi0304 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
  • Add memory and CPU resource limits to llama-stack container
    (requests: 500m CPU / 2Gi memory, limits: 2 CPU / 8Gi memory)
  • Add memory and CPU resource limits to lightspeed-service-api container
    (requests: 250m CPU / 512Mi memory, limits: 1 CPU / 2Gi memory)
  • Add memory and CPU resource limits to console plugin containers
    (requests: 50m CPU / 64Mi memory, limits: 200m CPU / 256Mi memory)
  • Update kuttl test assertions to verify resource limits

@openshift-ci openshift-ci Bot requested review from Akrog and umago June 10, 2026 13:52
@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee086cd8-c992-4767-ac9d-3fa61e403c4b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omkarjoshi0304 omkarjoshi0304 changed the title Add memory and CPU resource limits to containers missing them The lla… Add memory and CPU resource limits to containers Jun 10, 2026
@omkarjoshi0304 omkarjoshi0304 force-pushed the lcore branch 2 times, most recently from e8ec692 to 4632e71 Compare June 10, 2026 14:08
umago
umago previously approved these changes Jun 10, 2026
View reviewed changes
lpiwowar
lpiwowar suggested changes Jun 10, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One thing -> Commit message needs to be fixed 🙈

Image

lpiwowar
lpiwowar reviewed Jun 11, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is about ensuring that all pods have resource requests and limits set can you also please resolve the missing CPU limit on the PostgreSQL pod as well? 🙏

operator/internal/controller/postgres_deployment.go

Line 152 in 34d4f23

corev1.ResourceMemory: resource.MustParse("2Gi"),

@omkarjoshi0304

omkarjoshi0304 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Since this is about ensuring that all pods have resource requests and limits set can you also please resolve the missing CPU limit on the PostgreSQL pod as well? 🙏

operator/internal/controller/postgres_deployment.go

Line 152 in 34d4f23

corev1.ResourceMemory: resource.MustParse("2Gi"),

I missed it

@openshift-ci openshift-ci Bot removed the approved label Jun 11, 2026
@lpiwowar

lpiwowar commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@omkarjoshi0304 I guess you want to rebase on top latest lcore-migration. Fix from @umago is waiting there.

@lpiwowar lpiwowar self-requested a review June 11, 2026 15:17
@omkarjoshi0304

omkarjoshi0304 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@omkarjoshi0304 I guess you want to rebase on top latest lcore-migration. Fix from @umago is waiting there.

waiting for @umago PR to get merge

@lpiwowar

lpiwowar commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@omkarjoshi0304 it has already been merged -> #112

@omkarjoshi0304
Add memory and CPU resource limits to containers missing them
0948bd9 
The llama-stack and lightspeed-service-api containers had no resource
limits, allowing unlimited memory consumption. The console plugin
containers also lacked resource definitions. This adds appropriate
requests and limits to prevent unbounded resource usage and protect
node stability.
@omkarjoshi0304
Add CPU limit to PostgreSQL container
83bbcc4 
The PostgreSQL container was missing a CPU limit while having memory
limits set. Add CPU limit of 500m to match the approach of ensuring
all containers have both CPU and memory limits defined.
@omkarjoshi0304

omkarjoshi0304 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@omkarjoshi0304 it has already been merged -> #112

Done

umago
umago approved these changes Jun 12, 2026
View reviewed changes

@umago umago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Omkar!

@umago

umago commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 12, 2026
lpiwowar
lpiwowar approved these changes Jun 12, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!:)

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, omkarjoshi0304, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8faeaf1 into openstack-lightspeed:lcore-migration Jun 12, 2026
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Akrog Akrog Awaiting requested review from Akrog
2 more reviewers
@umago umago umago approved these changes
@lpiwowar lpiwowar lpiwowar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@umago umago

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omkarjoshi0304 @lpiwowar @umago